Add type hints to __main__.py #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggravlingen
commented
Mar 18, 2022
| def main(org_args): | ||
| """Run main.""" | ||
| global devices, homekit_id, light, api, lights, gateway, groups, moods, tasks, dump_devices, dump_all # pylint: disable=global-variable-undefined, invalid-name | ||
| if __name__ == "__main__": |
There was a problem hiding this comment.
By putting all the code here instead of in a function, we don't need the global definition, which was messing up the type hints.
This comment was marked as resolved.
This comment was marked as resolved.
|
I believe this concludes the task of adding type hints to the library? I remember you did a breaking change in one of the pull requests, albeit a small one. Should I bump to 10.0.0 or is this 9.1.0? If we're going for 10 we might as well drop the methods discussed in #457. |
MartinHjelmare
approved these changes
Mar 19, 2022
|
I think we can make a major bump after removing the stale methods. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type hints to
__main__.py.