Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to smart_task.py #456

Merged
merged 15 commits into from
Mar 15, 2022
Merged

Add type hints to smart_task.py #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
faa7d08
Add type hints StartActionItemController
ggravlingen Mar 10, 2022
682c9a8
Fix typo
ggravlingen Mar 10, 2022
58b8bd6
Add type hints
ggravlingen Mar 12, 2022
48c2908
Convert to int
ggravlingen Mar 12, 2022
552676b
Add type hints
ggravlingen Mar 13, 2022
8ee5c1d
FIx test
ggravlingen Mar 13, 2022
ae7105a
Make transition time optional
ggravlingen Mar 13, 2022
1a02149
Implement calibration method
ggravlingen Mar 13, 2022
261e30e
Improve setter
ggravlingen Mar 13, 2022
3a7a0c9
Remove setter
ggravlingen Mar 13, 2022
f6e91ec
Refactor
ggravlingen Mar 13, 2022
41575d5
Update pytradfri/smart_task.py
ggravlingen Mar 14, 2022
26f749c
Remove type annotation
ggravlingen Mar 14, 2022
c39c4e4
Fix?
ggravlingen Mar 14, 2022
b894c6d
Remove type hints
ggravlingen Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,3 +278,14 @@ disallow_untyped_defs = true
no_implicit_optional = true
warn_return_any = true
warn_unreachable = true

[mypy-pytradfri.smart_task]
check_untyped_defs = true
disallow_incomplete_defs = true
disallow_subclassing_any = true
disallow_untyped_calls = true
disallow_untyped_decorators = true
disallow_untyped_defs = true
no_implicit_optional = true
warn_return_any = true
warn_unreachable = true
4 changes: 2 additions & 2 deletions pytradfri/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class BaseResponse(BaseModel):
class ApiResourceResponse(BaseResponse):
"""Represent a resource response."""

name: str = Field(alias=ATTR_NAME)
name: Optional[str] = Field(alias=ATTR_NAME)
created_at: Optional[int] = Field(alias=ATTR_CREATED_AT)
ota_update_state: Optional[int] = Field(alias=ATTR_OTA_UPDATE_STATE)

Expand Down Expand Up @@ -51,7 +51,7 @@ def id(self) -> int:
return resource_id

@property
def name(self) -> str:
def name(self) -> str | None:
"""Name."""
if self._model_class:
name = self.raw.name # type: ignore[union-attr]
Expand Down
Loading