Minor type hint fixes

[ggravlingen]

Fixes:

pytradfri/device/__init__.py:29: error: Module "pytradfri.device.air_purifier_control" does not explicitly export attribute "AirPurifierResponse"; implicit reexport disabled  [attr-defined]
pytradfri/device/__init__.py:30: error: Module "pytradfri.device.blind_control" does not explicitly export attribute "BlindResponse"; implicit reexport disabled  [attr-defined]

[ggravlingen]

I ran mypy with the --strict option and saw those. We also have this:

pytradfri/command.py:35: error: Implicit generic "Any". Use "typing.List" and specify generic parameters  [type-arg]
pytradfri/command.py:35: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters  [type-arg]
pytradfri/command.py:60: error: Implicit generic "Any". Use "typing.List" and specify generic parameters  [type-arg]
pytradfri/command.py:60: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters  [type-arg]
pytradfri/command.py:84: error: Implicit generic "Any". Use "typing.List" and specify generic parameters  [type-arg]
pytradfri/command.py:84: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters  [type-arg]
pytradfri/command.py:122: error: Missing type parameters for generic type "Command"  [type-arg]
pytradfri/command.py:130: error: Missing type parameters for generic type "Command"  [type-arg]
pytradfri/util.py:15: error: Implicit generic "Any". Use "typing.List" and specify generic parameters  [type-arg]
pytradfri/util.py:15: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters  [type-arg]
pytradfri/util.py:35: error: Implicit generic "Any". Use "typing.List" and specify generic parameters  [type-arg]
pytradfri/util.py:35: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters  [type-arg]
pytradfri/api/libcoap_api.py:114: error: Missing type parameters for generic type "Command"  [type-arg]
pytradfri/api/aiocoap_api.py:56: error: Missing type parameters for generic type "Task"  [type-arg]
pytradfri/api/aiocoap_api.py:225: error: Missing type parameters for generic type "Command"  [type-arg]
pytradfri/api/aiocoap_api.py:301: error: Implicit generic "Any". Use "typing.List" and specify generic parameters  [type-arg]
pytradfri/api/aiocoap_api.py:301: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters  [type-arg]
pytradfri/api/aiocoap_api.py:323: error: Implicit generic "Any". Use "typing.List" and specify generic parameters  [type-arg]
pytradfri/api/aiocoap_api.py:323: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters  [type-arg]

These will not be relevant when we remove the two Command-methods __add__ and combine:

pytradfri/command.py:122: error: Missing type parameters for generic type "Command"  [type-arg]
pytradfri/command.py:130: error: Missing type parameters for generic type "Command"  [type-arg]

But what about these, can they be fixed by adding [T] to the type hint?

pytradfri/api/libcoap_api.py:114: error: Missing type parameters for generic type "Command"  [type-arg]
pytradfri/api/aiocoap_api.py:56: error: Missing type parameters for generic type "Task"  [type-arg]
pytradfri/api/aiocoap_api.py:225: error: Missing type parameters for generic type "Command"  [type-arg]

[MartinHjelmare]

Yes, the Command cases in the api module should use T. The Task should be typed with its result value.

The list and dict cases should just add explicit Any where needed instead of implicit.

[ggravlingen]

Yes, the Command cases in the api module should use T. The Task should be typed with its result value.

The list and dict cases should just add explicit Any where needed instead of implicit.

Thanks, I've stored your remarks and will look into them later.