Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pydantic for sockets #435

Merged
merged 8 commits into from
Feb 26, 2022
Merged

Implement pydantic for sockets #435

merged 8 commits into from
Feb 26, 2022

Conversation

ggravlingen
Copy link
Member

No description provided.

MartinHjelmare
MartinHjelmare reviewed Feb 26, 2022
View reviewed changes
pytradfri/device/socket.py Show resolved Hide resolved
pytradfri/device/socket_control.py Outdated Show resolved Hide resolved
pytradfri/device/socket_control.py Outdated Show resolved Hide resolved
@ggravlingen
Copy link
Member Author

I ended up having to change an unrelated file. Should I revert and add that file to mypy.ini in a separate PR?

@MartinHjelmare
Copy link
Contributor

You decide. It's ok I think.

@ggravlingen
Copy link
Member Author

You decide. It's ok I think.

Then I leave it and move on to lights.

@ggravlingen ggravlingen merged commit 672a1f0 into master Feb 26, 2022
@ggravlingen ggravlingen deleted the implement-pydantic-socket branch February 26, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggravlingen @MartinHjelmare