Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch OSError and socket.gaierror #189

Merged
merged 3 commits into from
Oct 3, 2018
Merged

Catch OSError and socket.gaierror #189

merged 3 commits into from
Oct 3, 2018

Conversation

balloob
Copy link
Collaborator

@balloob balloob commented Oct 2, 2018

Catch OSError and socket.gaierror when fetching a response with aiocoap.

Can be removed when upstream issue fixed: chrysn/aiocoap#124

@balloob balloob changed the title Catch OS Error Catch OSError and socket.gaierror Oct 2, 2018
@lwis
Copy link
Collaborator

lwis commented Oct 2, 2018

Could you bump the version please, and I'll include this with my shutdown changes for HA.

@coveralls
Copy link

coveralls commented Oct 2, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 78.958% when pulling dc31178 on catch-os-error into a421633 on master.

@ggravlingen
Copy link
Member

I'll push to pypi once merged

@lwis lwis merged commit 514669b into master Oct 3, 2018
@lwis lwis deleted the catch-os-error branch October 3, 2018 20:09
@balloob balloob mentioned this pull request Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should OSError be wrapped?
4 participants
@balloob @lwis @coveralls @ggravlingen