Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown function for ensuring it's possible to unsubscribe before closing event loops #186

Merged
merged 3 commits into from
Oct 1, 2018
Merged

Shutdown function for ensuring it's possible to unsubscribe before closing event loops #186

merged 3 commits into from
Oct 1, 2018

Conversation

lwis
Copy link
Collaborator

@lwis lwis commented Oct 1, 2018 •
edited
Loading

Fixes #181

This will need to be called by downstream projects before shutdown.

@coveralls
Copy link

coveralls commented Oct 1, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 79.437% when pulling c22b7f2 on aio_shutdown into e4338c0 on master.

ggravlingen
ggravlingen requested changes Oct 1, 2018
View reviewed changes
Copy link
Member

@ggravlingen ggravlingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need a version bump too?

@lwis
Copy link
Collaborator Author

lwis commented Oct 1, 2018

@ggravlingen Good spot, rectified.

ggravlingen
ggravlingen approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@ggravlingen ggravlingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 please feel free to merge this PR.

@lwis lwis merged commit 1fce816 into master Oct 1, 2018
@lwis lwis deleted the aio_shutdown branch October 1, 2018 18:24
@ggravlingen
Copy link
Member

Just pushed this to pypi.

@lwis
Copy link
Collaborator Author

lwis commented Oct 2, 2018

@ggravlingen ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggravlingen ggravlingen ggravlingen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lwis @coveralls @ggravlingen