Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of debug info file & examples folder #148

Merged
merged 4 commits into from
Jan 29, 2018

Conversation

Lakitna
Copy link
Contributor

@Lakitna Lakitna commented Jan 28, 2018

As discussed at the end of #135

The solution I've used works using the default import methods, but it's a hack. So don't use this solution in production code if it can be helped.

Closes #135

@coveralls
Copy link

coveralls commented Jan 28, 2018

Coverage Status

Coverage remained the same at 64.645% when pulling b5d658d on Lakitna:Debug-info-file into 7479378 on ggravlingen:master.

@Lakitna Lakitna changed the title Addition of debug info file Addition of debug info file & examples folder Jan 28, 2018
@ggravlingen
Copy link
Member

Thank you very much! I'm fine with this 'hack' as it cleans up the root dir.

@ggravlingen
Copy link
Member

@Lakitna perhaps also update the README as it references the examples?

@ggravlingen ggravlingen self-assigned this Jan 29, 2018
@@ -1,7 +1,7 @@
[![Coverage Status](https://coveralls.io/repos/github/ggravlingen/pytradfri/badge.svg?branch=master)](https://coveralls.io/github/ggravlingen/pytradfri?branch=master)
[![PyPI version](https://badge.fury.io/py/pytradfri.svg)](https://badge.fury.io/py/pytradfri)

**NB:** Latest Gateway version tested and working - 1.2.42.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't properly rebase my fork before starting working on this. I rebased readme manually, this is an artifact of that.

@Lakitna
Copy link
Contributor Author

Lakitna commented Jan 29, 2018

@ggravlingen I agree, I've updated readme. I think that makes it ready to merge.

@ggravlingen ggravlingen merged commit e7fa96a into home-assistant-libs:master Jan 29, 2018
@ggravlingen
Copy link
Member

Thank you very much @Lakitna!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants