Psk handling clarification #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now only for a single example, I still have to test it with a Gateway.
Also changed some comments and stuff
|
Interactive mode still needs to be changed to the new KEY input method. Readme could use some love too. @ggsubs I'd like your opinion :) |
|
Nice, thank you! Do you want to await comments from @ggsubs before I merge? |
|
I'd like to change interactive mode too before merging. That'll give @ggsubs time to comment as well. |
|
@Lakitna OK! |
Simplified thing a bit on the terminal side.
Interactive mode now uses the same methods as the examples, including the prompt for the KEY. Readme has been updated accordingly.
houndci-bot
reviewed
Jan 15, 2018
| 'key': psk} | ||
| save_json(CONFIG_FILE, conf) | ||
| except AttributeError: | ||
| raise PytradfriError("Please provide the 'Security Code' on the " |
There was a problem hiding this comment.
'PytradfriError' may be undefined, or defined from star imports: .const
| "Tradfri gateway:", end=" ") | ||
| key = input().strip() | ||
| if len(key) != 16: | ||
| raise PytradfriError("Invalid 'Security Code' provided.") |
There was a problem hiding this comment.
'PytradfriError' may be undefined, or defined from star imports: .const
|
Any change suggestions? If not it's ready to merge. |
lwis
approved these changes
Jan 16, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#133