Add transition_time to more methods #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 23, 2017
pytradfri/device.py
Outdated
| try: | ||
| color = COLORS[colorname.lower().replace(" ", "_")] | ||
| return self.set_hex_color(color, index=index) | ||
| return self.set_hex_color(color, index=index, transition_time=transition_time) |
There was a problem hiding this comment.
line too long (90 > 79 characters)
pytradfri/device.py
Outdated
|
|
||
| def set_predefined_color(self, colorname, *, index=0): | ||
| def set_predefined_color(self, colorname, *, index=0, transition_time=None): |
There was a problem hiding this comment.
line too long (80 > 79 characters)
pytradfri/device.py
Outdated
|
|
||
| def set_hsb(self, hue, saturation, brightness, *, index=0): | ||
| def set_hsb(self, hue, saturation, brightness, *, index=0, transition_time=None): |
There was a problem hiding this comment.
line too long (85 > 79 characters)
Added to and tested for the following methods: - set_color_temp - set_hex_color - set_xy_color - set_hsb - set_predefined_color
jurriaan
force-pushed
the
transition-all-the-things
branch
from
2cf3bc9 to
a345471
Compare
|
Thanks! 🐊 Are you planning on making the upstream changes in HA? |
|
Thank you @jurriaan! I have pushed this as 5.1.0 to pypi now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to and tested for the following methods: