Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dimmer data validation #109

Merged
merged 1 commit into from
Nov 12, 2017
Merged

Dimmer data validation #109

merged 1 commit into from
Nov 12, 2017

Conversation

lwis
Copy link
Collaborator

@lwis lwis commented Nov 12, 2017

No description provided.

@coveralls
Copy link

coveralls commented Nov 12, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 63.457% when pulling 0afbb69 on data_validation into ec6d395 on master.

Lakitna
Lakitna reviewed Nov 12, 2017
View reviewed changes
Copy link
Contributor

@Lakitna Lakitna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively you could use if 0 < dimmer < 254: to make it even cleaner.

@ggravlingen ggravlingen merged commit 3898172 into master Nov 12, 2017
@ggravlingen ggravlingen deleted the data_validation branch November 12, 2017 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lakitna Lakitna Lakitna left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lwis @coveralls @Lakitna @ggravlingen