Refactor Matter server and client #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
balloob
reviewed
Nov 29, 2022
balloob
reviewed
Nov 29, 2022
| @@ -1,250 +0,0 @@ | |||
| """Matter base class.""" | |||
There was a problem hiding this comment.
Discussed offline with Marcel. We're going to re-instate this file again to split again the Matter from WebSocket logic.
|
as greed, we're going to merge this one and fix remaining issues and improvements later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost a complete rewrite, mainly because I needed to wrap my head around Matter and its models and because we changed the approach a bit.
DRAFT, still some work in progress and last bugs to fix!