Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Websocket commands doc into docs directory #981

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Nov 30, 2024

  • To shorten the main page, move Websocket commands doc into docs directory
  • Add 'Read an attribute' in README
  • Add 'Write an attribute' to README

Read an attribute
Add 'Write an attribute' to README
@lboue lboue changed the title Add 'Read an attribute' in README Add Read/Write an attribute in README Nov 30, 2024
@lboue lboue marked this pull request as ready for review November 30, 2024 17:45
@agners
Copy link
Collaborator

agners commented Dec 4, 2024

Maybe it would be better if we have the WS protocol description in a separate docs folder? 🤔

@agners agners added the docs Changes to README/documentation within the repo label Dec 4, 2024
@lboue
Copy link
Contributor Author

lboue commented Dec 4, 2024

Maybe it would be better if we have the WS protocol description in a separate docs folder? 🤔

I tend to agree with that.

@lboue lboue changed the title Add Read/Write an attribute in README Move Websocket commands doc into docs directory Dec 4, 2024
@lboue
Copy link
Contributor Author

lboue commented Dec 4, 2024

Is it OK for you this way?

README.md Outdated Show resolved Hide resolved
Co-authored-by: Marcel van der Veldt <m.vanderveldt@outlook.com>
@marcelveldt marcelveldt added the ci Improvements or additions to the CI actions label Dec 5, 2024
@marcelveldt marcelveldt merged commit 6c5b87e into home-assistant-libs:main Dec 5, 2024
4 of 5 checks passed
@marcelveldt
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Improvements or additions to the CI actions docs Changes to README/documentation within the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants