Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to CHIP version a1643eee5e (2022-08-10 00:03:09 -0700) #60

Merged
merged 8 commits into from
Aug 12, 2022

Conversation

agners
Copy link
Collaborator

@agners agners commented Aug 10, 2022

@agners
Copy link
Collaborator Author

agners commented Aug 10, 2022

This currently fails to serialize a complete device read with:

TypeError: WrongTypeError.__init__() missing 2 required positional arguments: 'field_type' and 'value'

@agners
Copy link
Collaborator Author

agners commented Aug 10, 2022

There are 4 Cluster Objects which fail deserialization (TLV deserialization which is part of the CHIP Python code):

2022-08-10 21:32:25 allenwind root[2394191] ERROR Error converting TLV to Cluster Object for path: Endpoint = 0, cluster = <class 'chip.clusters.Objects.ThreadNetworkDiagnostics'>
2022-08-10 21:32:25 allenwind root[2394191] ERROR |-- Exception: ValueError("Failed to decode field [].channel, expected type <class 'chip.tlv.uint'>, got <class 'chip.clusters.Attribute.ValueDecodeFailure'>")
2022-08-10 21:32:25 allenwind root[2394191] ERROR Error converting TLV to Cluster Object for path: Endpoint = 0, cluster = <class 'chip.clusters.Objects.WiFiNetworkDiagnostics'>
2022-08-10 21:32:25 allenwind root[2394191] ERROR |-- Exception: WrongTypeError()
2022-08-10 21:32:25 allenwind root[2394191] ERROR Error converting TLV to Cluster Object for path: Endpoint = 0, cluster = <class 'chip.clusters.Objects.AdministratorCommissioning'>
2022-08-10 21:32:25 allenwind root[2394191] ERROR |-- Exception: WrongTypeError()
2022-08-10 21:32:25 allenwind root[2394191] ERROR Error converting TLV to Cluster Object for path: Endpoint = 1, cluster = <class 'chip.clusters.Objects.TestCluster'>
2022-08-10 21:32:25 allenwind root[2394191] ERROR |-- Exception: ValueError("Failed to decode field [].generalErrorBoolean, expected type <class 'bool'>, got <class 'chip.clusters.Attribute.ValueDecodeFailure'>")

Some of them have been there before, but what is new is that some cause a WrongTypeError exception. it seems that our JSON serializer chocks on those.

@agners
Copy link
Collaborator Author

agners commented Aug 10, 2022

With the last commit the serialization issue is addressed. Controlling a light seems to work again.

@balloob
Copy link
Contributor

balloob commented Aug 11, 2022

In 0d99365 you manually removed some things from device_types.py. Instead you should update the generate script to address these issues.

@agners
Copy link
Collaborator Author

agners commented Aug 11, 2022

Seems when they got removed from various places but matter-devices.xml got missed. Created a PR project-chip/connectedhomeip#21818. Regenerated the devices using that updated xml.

@balloob
Copy link
Contributor

balloob commented Aug 11, 2022

We are the only people using that XML I think 😬

@agners agners merged commit b5678b7 into main Aug 12, 2022
@agners agners deleted the bump-to-a1643eee5e branch August 12, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants