-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope link-local IPv6 addresses received from WebSocket #501
Merged
marcelveldt
merged 6 commits into
home-assistant-libs:main
from
agners:scope-link-local-addresses-for-commissioning-with-ip
Jan 11, 2024
Merged
Scope link-local IPv6 addresses received from WebSocket #501
marcelveldt
merged 6 commits into
home-assistant-libs:main
from
agners:scope-link-local-addresses-for-commissioning-with-ip
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release supports scope_id in the CommissionIP API.
When receiving link-local IPv6 addresses, remove the scope by default as the scope id is typically from a remote machine (e.g. from the Android phone). If the Matter server got started with a primary interface set, scope the link-local address to that interface instead. This fixes commissioning issue for WiFi devices when using the Android in-app commissioning flow which sends the IP address alongside. Related-to: home-assistant-libs#463
I've tested that with an Android App build which has #4069 merged, and things seem to work as they should:
This will need an add-on change (to pass |
marcelveldt
reviewed
Jan 11, 2024
marcelveldt
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one comment (to fix the lint issue)
Jc2k
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope link-local IPv6 addresses received from WebSocket
When receiving link-local IPv6 addresses, remove the scope by default
as the scope id is typically from a remote machine (e.g. from the Android
phone).
If the Matter server got started with a primary interface set, scope the
link-local address to that interface instead.
This fixes commissioning issue for WiFi devices when using the Android
in-app commissioning flow which sends the IP address of the device
to be commissioned alongside.
This also bumps the CHIP wheels to the latest version v2024.1.0 which is
required for interface id support in the
ConnectIP
IP (seehome-assistant-libs/chip-wheels#27).
Related-to: #463