Add temporary guard for infinite loop in resub logic #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
approved these changes
Nov 4, 2023
| cur_timestamp = time.time() | ||
| if ( | ||
| nextResubscribeIntervalMsec > 30000 | ||
| and (cur_timestamp - node.last_subscription_attempt) < 2 |
There was a problem hiding this comment.
Suggested change
| and (cur_timestamp - node.last_subscription_attempt) < 2 | |
| and cur_timestamp - node.last_subscription_attempt < 2 |
|
You didn't remove the parenthesis that aren't needed. |
|
Correct, they were there on purpose of readability to group the two elements. This code is temporary anyway |
|
I think the parenthesis makes it harder to read. |
Yeah, might be a matter of personal preference I guess, I like to group the calculations but strictly taken that i not needed in this case. If this temporary code is not gone in 3 days - I'll remove the parentheses in a follow-up ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got reports about an infinite loop in the sdk resubscription logic where the resubscription is attempted without respecting the timeout, causing an endless loop consuming a full cpu core.
Awaiting further investigation I have now put in a quick guard in the code that detects the infinite loop, logs it as error and tears down the subscription. The reconnect is then handled by our poll logic.
Closes #426