Fix issues with parsing models on Python 3.9 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Dec 1, 2022
| @@ -35,7 +35,7 @@ | |||
| except: # noqa | |||
| # older python version | |||
| NoneType = type(None) | |||
| UnionType = type(int | str) | |||
There was a problem hiding this comment.
The reason this doesn't work with from __future__ is because it is not written inside an annotation.
There was a problem hiding this comment.
Yeah, missed that while in the rush
balloob
reviewed
Dec 1, 2022
| @@ -87,15 +87,20 @@ def parse_utc_timestamp(datetimestr: str): | |||
| return datetime.fromisoformat(datetimestr.replace("Z", "+00:00")) | |||
|
|
|||
|
|
|||
| def parse_value(name: str, value: Any, value_type: Type | str, default: Any = MISSING): | |||
| def parse_value( | |||
| name: str, value: Any, value_type: Union[Type, str], default: Any = MISSING | |||
There was a problem hiding this comment.
this is inside an annotation so would have been fine.
There was a problem hiding this comment.
Yeah, unrelated. The issue was the parsing of the actual annotations in this function itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Union types need to be written the oldskool way (even with annotations from future), otherwise our dynamic model creation does not work on python 3,9 causing import errors.