Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ice servers to async WebRTC offer #4

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

edenhaus
Copy link
Collaborator

@edenhaus edenhaus commented Oct 23, 2024

Proposed Changes

Add ice servers to async WebRTC offer
Requires AlexxIT/go2rtc#1408

Related Issues

(Github link to related issues or pull requests)

@edenhaus edenhaus added the enhancement Enhancement of the code, not introducing new features. label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.99%. Comparing base (140d2cb) to head (d9e2c6a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
go2rtc_client/ws/messages.py 96.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   97.14%   96.99%   -0.16%     
==========================================
  Files           7        7              
  Lines         245      266      +21     
  Branches       35       43       +8     
==========================================
+ Hits          238      258      +20     
  Misses          5        5              
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edenhaus edenhaus marked this pull request as ready for review October 28, 2024 12:54
@MartinHjelmare MartinHjelmare merged commit 9c6c543 into main Oct 28, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants