Add info about Gen4 devices #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemelli74
reviewed
Jan 6, 2025
aioshelly/const.py
Outdated
| @@ -918,6 +922,34 @@ class ShellyDevice: | |||
| gen=GEN3, | |||
| supported=True, | |||
| ), | |||
| MODEL_1PM_G4: ShellyDevice( | |||
| model="S4SW-001P16EU", | |||
There was a problem hiding this comment.
Why we always write the model manually instead of using MODEL_1PM_G4 as it's already there ?
There was a problem hiding this comment.
Good question, I don't know 😄
|
Thx! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
==========================================
+ Coverage 38.73% 38.91% +0.18%
==========================================
Files 15 15
Lines 1451 1457 +6
==========================================
+ Hits 562 567 +5
- Misses 889 890 +1 ☔ View full report in Codecov by Sentry. |
thecode
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.