Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: health monitoring cpu temp ring when no data, disks health when no data #2029

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: health monitoring cpu temp ring when no data, disks health when no data #2029

merged 1 commit into from
Jan 20, 2025

Conversation

hillaliy
Copy link
Contributor

@hillaliy hillaliy commented Jan 20, 2025 •
edited by Meierschlumpf
Loading


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@hillaliy hillaliy added the bug Something isn't working label Jan 20, 2025
@hillaliy hillaliy self-assigned this Jan 20, 2025
@hillaliy hillaliy requested a review from a team as a code owner January 20, 2025 15:06
@hillaliy
Copy link
Contributor Author

image

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Jan 20, 2025

Here's the code health analysis summary for commits 45af644..ecd36d1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.05% 8268 / 39266
🔵 Statements 21.05% 8268 / 39266
🔵 Functions 25.12% 306 / 1218
🔵 Branches 61.76% 908 / 1470
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/widgets/src/health-monitoring/system-health.tsx 0% 0% 0% 0% 1-423
Generated in workflow #4690 for commit ecd36d1 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf changed the title fix: health monitoring cpu temp ring when no data, disks health when … fix: health monitoring cpu temp ring when no data, disks health when no data Jan 20, 2025
@Meierschlumpf
Copy link
Member

image

What is the 0 between the two?

@hillaliy
Copy link
Contributor Author

hillaliy commented Jan 20, 2025 •
edited
Loading

image

What is the 0 between the two?

This is how it appears now, this PR fix it to this
Screenshot 2025-01-20 at 21 18 46

@Meierschlumpf Meierschlumpf merged commit bdefff6 into dev Jan 20, 2025
19 checks passed
@hillaliy hillaliy deleted the health-monitoring-cpu-temp-and-disks-health branch January 20, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meierschlumpf Meierschlumpf Meierschlumpf approved these changes

Assignees

@hillaliy hillaliy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hillaliy @Meierschlumpf