Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add item does not respect dynamic sections #2010

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #1992

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Jan 18, 2025
@Meierschlumpf Meierschlumpf self-assigned this Jan 18, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner January 18, 2025 20:40
Copy link

deepsource-io bot commented Jan 18, 2025

Here's the code health analysis summary for commits fa6262c..0da9725. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Jan 18, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.33% 8399 / 39374
🔵 Statements 21.33% 8399 / 39374
🔵 Functions 25.49% 312 / 1224
🔵 Branches 62.36% 951 / 1525
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/components/board/items/item-actions.tsx 0% 0% 0% 0% 1-237
apps/nextjs/src/components/board/items/actions/create-item.ts 92.68% 81.81% 100% 92.68% 29-31
apps/nextjs/src/components/board/items/actions/duplicate-item.ts 68.25% 62.5% 100% 68.25% 38-60
apps/nextjs/src/components/board/items/actions/empty-position.ts 100% 100% 100% 100%
apps/nextjs/src/components/board/items/actions/test/shared.ts 100% 77.77% 100% 100%
Generated in workflow #4681 for commit 0da9725 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf changed the title bug: add item does not respect dynamic sections fix: add item does not respect dynamic sections Jan 18, 2025
@Meierschlumpf Meierschlumpf merged commit d4f04da into dev Jan 21, 2025
12 of 13 checks passed
@Meierschlumpf Meierschlumpf deleted the add-item-bug branch January 21, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: add item does not respect dynamic sections
1 participant