Use liftstd for BasisOfRowsCoeff #476
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runtime of the added example drops from 25s to 6s on my computer. Notes: * This commit is very unfinished. Its only purpose is to show the potential and for quick tests. * `liftstd(..., "std")` has the same output as `std` but only up to clearing denominators, so one would also have to adjust `std`, `syz` etc. * Using the relative version of `liftstd` one could also implement a more efficient `RelativeBasisOfRowsCoeff`. * https://github.com/zickgraf/homalg_project/tree/use_liftstd has some more experiments in this direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime of the added example drops from 25s to 6s on my computer.
Notes:
and for quick tests.
liftstd(..., "std")has the same output asstdbut only up toclearing denominators, so one would also have to adjust
std,syzetc.liftstdone could also implement a moreefficient
RelativeBasisOfRowsCoeff.experiments in this direction.