Fix use of attributes instead of their testers in method filters #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/fix-EvalCertainRows-abuse
branch
from
cb9bcc6 to
7a9e0f6
Compare
fingolfin
changed the title
This code was accepted by GAP and silently treated as the same as in the fixed versions; but this will change in a future GAP release. For details see <gap-system/gap#2732>
fingolfin
force-pushed
the
mh/fix-EvalCertainRows-abuse
branch
from
7a9e0f6 to
d77850c
Compare
|
Many thanks. |
|
@sebasguts this PR is not yet in the release of MatricesForHomalg, isn't it? It is blocking gap-system/gap#2756 then. |
3 tasks
|
@mohamed-barakat Should I do the release or are you going to do it? |
|
I probably didn't make a release because of the missing Jenkins. I am now ahead of this PR. Could you please make a release of this PR-merge. I can only hope that nothing breaks. |
|
I did further investigation, and in fact, this PR was released with the |
|
@sebasguts ok, but how does it happen that version 2018.08.25 dated 25/08/2018 has a PR that has been merged on August 28th? |
HereAround
pushed a commit
to HereAround/homalg_project
that referenced
this pull request
Jun 18, 2020
…inRows-abuse Fix use of attributes instead of their testers in method filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was accepted by GAP and silently treated as the same as in the fixed versions; but this will change in a future GAP release.
For details see gap-system/gap#2732
It would be kinda cool if this fix could make it into a homalg release before GAP 4.10 is released. But of course that's not much time (a week or so), so we may just end up delaying that fix to GAP 4.11.