Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyMakeInterface build doesn't report failures to BuildPackages.sh #221

Closed
RussWoodroofe opened this issue Nov 24, 2018 · 11 comments
Closed

Comments

@RussWoodroofe
Copy link

When running BuildPackages from GAP on a system without Polymake, PolymakeInterface (of course) fails to build. However, it doesn't report its failure, and doesn't appear in fail.log.

This is a follow-on to GAP issue #2971, linked here:
gap-system/gap#2971 (comment)
@fingolfin had some helpful comments there about what was wrong, and how to fix it.

@RussWoodroofe
Copy link
Author

This is still an issue in GAP 4.11.

@mohamed-barakat
Copy link
Member

@sebasguts @alex-konovalov. I am in favor of removing PolymakeInterface from GAP's distribution. We do not maintain it anymore. Internally we switched to NormalizInterface and can now access polymake through OSCAR (https://github.com/oscar-system/).

@olexandr-konovalov
Copy link

@mohamed-barakat @sebasguts are there any of your packages that have PolymakeInterface in their dependencies?

@kamalsaleh
Copy link
Member

PolymakeInterface is a suggested-other-package in the Convex package.

@mohamed-barakat
Copy link
Member

Yes, Convex should also be dropped from homalg_project.

@mohamed-barakat
Copy link
Member

@alex-konovalov: Please drop PolymakeInterface and Convex from the future GAP distribution. They are now replaced by NormalizInterface and NConvex.

@mohamed-barakat
Copy link
Member

We stopped supporting PolymakeInterface and Convex and they will not be deposited with GAP in the future. The part of their functionality we use in ToricVarieties is now covered by the deposited packages NormalizeInterface, CddInterface, and NConvex, the last two maintained by @kamalsaleh. Any future use of polymake will be through Polymake.jl which is a component of Oscar.

@mohamed-barakat
Copy link
Member

I will close this issue soon.

@olexandr-konovalov
Copy link

@mohamed-barakat have you checked that the action is done? Because I do not remember sseing this and https://www.gap-system.org/Packages/polymakeinterface.html is still there. If this is still OK, please submit an issue at https://github.com/gap-system/gap-distribution or even a PR to https://github.com/gap-system/gap-distribution/blob/master/DistributionUpdate/PackageUpdate/currentPackageInfoURLList to withdraw the package.

@mohamed-barakat
Copy link
Member

Thanks, I will make a PR.

I will then withdraw PolymakeInterface and Convex:

What about the two files

  • `wininst/gap.nsi
  • wininst/wininst.g

Do I need to modify them as well?

@olexandr-konovalov
Copy link

I will then withdraw PolymakeInterface and Convex:

Only the 1st one (Convex already replaced by NConvex)

What about the two files

wininst/gap.nsi
wininst/wininst.g

Do I need to modify them as well?

Modify only wininst/wininst.g please. The other is autogenerated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants