intersection and spatial join support for Point arrays #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comment with the numba error message
jbednar
reviewed
Jan 10, 2020
|
|
||
| from spatialpandas.geometry.base import GeometryDtype | ||
| from spatialpandas.geometry.basefixed import GeometryFixed, GeometryFixedArray | ||
| from dask.dataframe.extensions import make_array_nonempty | ||
| from spatialpandas.utils import ngpjit |
There was a problem hiding this comment.
Should these be relative imports? Seems odd to see imports from "spatialpandas" inside spatialpandas.
There was a problem hiding this comment.
They could be, but this library is already Python 3 only (due to pandas dependency) so it works either way.
spatialpandas/tools/sjoin.py
Outdated
| rsuffix: Suffix to apply to overlapping column names from the right GeoDataFrame | ||
|
|
||
| Returns: | ||
| GeoDataFrame or DaskGeoDataFrame |
There was a problem hiding this comment.
Where the type returned depends on left_df?
Added comment with the numba error message
…to point_intersect
60 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an initial partial implementation of the
intersectsandsjoinoperations.From the updated Overview notebook:
The most common use-case that this functionality is designed to support is performing a spatial join between a large
GeoDataFrameorDaskGeoDataFrameof Points and a small to moderate sizedGeoDataFrameof (Multi)Polygons.As usual, the new functionality is tested against geopandas using hypothesis property tests.