Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow type change for DateRange and Date #733

Merged
merged 5 commits into from
Apr 17, 2023
Merged

Allow type change for DateRange and Date #733

merged 5 commits into from
Apr 17, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Apr 12, 2023

Fixes holoviz/panel#4566

This adds support for having both datetime.date and datetime.datetime values in param.DateRange.

@maximlt maximlt changed the title Allow type change for DateRange Allow type change for DateRange and Date Apr 17, 2023
@maximlt
Copy link
Member

maximlt commented Apr 17, 2023

Thanks for that @hoxbro! I've made some changes, mostly to add the same behavior to Date so that Param offers a consistent behavior for these two Parameters. Let me know if you want to review it?

hoxbro
hoxbro commented Apr 17, 2023
View reviewed changes
@maximlt @hoxbro
Update param/__init__.py
d918a75 
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@maximlt
Copy link
Member

maximlt commented Apr 17, 2023

Thanks for the review!

@maximlt maximlt merged commit 28cad89 into main Apr 17, 2023
@maximlt maximlt deleted the allow_type_change_for_DateRange branch April 17, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using pn.DateRangeSlider with datetime.date return param error
2 participants
@hoxbro @maximlt