Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sentinel value for inheriting parameter slots #605

Merged
merged 51 commits into from
Apr 12, 2023
Merged

Use sentinel value for inheriting parameter slots #605

merged 51 commits into from
Apr 12, 2023

Commits on Feb 11, 2022

  1. Replace None with _Undefined in constructors, and move validation to … 

    …the ParameterizedMetaclass
    @jbednar
    jbednar committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    7f3bc09 View commit details
    Browse the repository at this point in the history

  2. Force TimeSampledFn to have a None default

    @jbednar
    jbednar committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    8225ae4 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2022

  1. Reverted numbergen change

    @jbednar
    jbednar committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    6aca386 View commit details
    Browse the repository at this point in the history

  2. Changed validation to accept _Undefined instead of being deferred

    @jbednar
    jbednar committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    98cc7c8 View commit details
    Browse the repository at this point in the history

  3. Minor cleanup

    @jbednar
    jbednar committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    df0c9f7 View commit details
    Browse the repository at this point in the history

  4. Renamed _Undefined to Undefined

    @jbednar
    jbednar committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    c776609 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Replaced un() with _slot_defaults + getattribute

    @jbednar
    jbednar committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    ce9b249 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Added support for callable default values

    @jbednar
    jbednar committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    20215a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Merge branch 'main' into undefined

    @maximlt
    maximlt committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    4633477 View commit details
    Browse the repository at this point in the history

  2. make dict_update private

    @maximlt
    maximlt committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    0ad7368 View commit details
    Browse the repository at this point in the history

  3. remove unused and broken check

    @maximlt
    maximlt committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    5978e38 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. set slot defaults for String

    @maximlt
    maximlt committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    8d5b095 View commit details
    Browse the repository at this point in the history

  2. move _dict_update to parameterized

    @maximlt
    maximlt committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    86e8d85 View commit details
    Browse the repository at this point in the history

  3. add _slots_defaults to Bytes

    @maximlt
    maximlt committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    cd2537a View commit details
    Browse the repository at this point in the history

  4. update slot defaults of the direct super class

    @maximlt
    maximlt committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    73a2d4b View commit details
    Browse the repository at this point in the history

  5. update the docstring to refer to Undefined

    @maximlt
    maximlt committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    42266e7 View commit details
    Browse the repository at this point in the history

  6. update Bytes parameter to use the sentinel

    @maximlt
    maximlt committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    208356f View commit details
    Browse the repository at this point in the history

  7. make allow_None_default private

    @maximlt
    maximlt committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    9e95d28 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2023

  1. Merge branch 'main' into undefined

    @maximlt
    maximlt committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    3d87987 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. refactor setting allow_None

    @maximlt
    maximlt committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    cc6b1da View commit details
    Browse the repository at this point in the history

  2. refactor setting instantiate

    @maximlt
    maximlt committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    107df6f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into undefined

    @maximlt
    maximlt committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5f28ac5 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. clean up

    @maximlt
    maximlt committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    538e826 View commit details
    Browse the repository at this point in the history

  2. fix comparison with Undefined

    @maximlt
    maximlt committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    2379afb View commit details
    Browse the repository at this point in the history

  3. undo FileSelector changes

    @maximlt
    maximlt committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    2298f03 View commit details
    Browse the repository at this point in the history

  4. re-set signature of Bytes

    @maximlt
    maximlt committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    8b5a5e0 View commit details
    Browse the repository at this point in the history

  5. all slots must have a default value

    @maximlt
    maximlt committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    8fb5f09 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Merge branch 'main' into undefined

    @maximlt
    maximlt committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    1077f2c View commit details
    Browse the repository at this point in the history

  2. dynamic update of Tuple length

    @maximlt
    maximlt committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    dd634a6 View commit details
    Browse the repository at this point in the history

  3. define Selector default values

    @maximlt
    maximlt committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    f765b56 View commit details
    Browse the repository at this point in the history

  4. define List default values

    @maximlt
    maximlt committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    88f9a9d View commit details
    Browse the repository at this point in the history

  5. fix List inheritance

    @maximlt
    maximlt committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    d1c44aa View commit details
    Browse the repository at this point in the history

  6. fix comments

    @maximlt
    maximlt committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    15c3cd6 View commit details
    Browse the repository at this point in the history

  7. update Number behavior test

    @maximlt
    maximlt committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    1211088 View commit details
    Browse the repository at this point in the history

  8. fix Selector behavior and adjust tests

    @maximlt
    maximlt committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    3d9f6fd View commit details
    Browse the repository at this point in the history

  9. adjust tuple tests

    @maximlt
    maximlt committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    854a8cb View commit details
    Browse the repository at this point in the history

  10. adjust parameterized tests

    @maximlt
    maximlt committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    59843b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Merge branch 'main' into undefined

    @maximlt
    maximlt committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    5175ad0 View commit details
    Browse the repository at this point in the history

  2. set Tuple length when default is provided

    @maximlt
    maximlt committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    b522d4a View commit details
    Browse the repository at this point in the history

  3. raise when Undefined is compared

    @maximlt
    maximlt committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    953edb4 View commit details
    Browse the repository at this point in the history

  4. raise better error when a slot has no default value

    @maximlt
    maximlt committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    576e079 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. Apply suggestions from code review

    @jbednar
    jbednar authored Mar 25, 2023
    Configuration menu
    Copy the full SHA
    c021efe View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. rename to _compute_length_of_default

    @maximlt
    maximlt committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    58c688c View commit details
    Browse the repository at this point in the history

  2. apply suggestion and rename

    @maximlt
    maximlt committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f294b57 View commit details
    Browse the repository at this point in the history

  3. rename selector default function

    @maximlt
    maximlt committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    03b9f4c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into undefined

    @maximlt
    maximlt committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    8a3e4f2 View commit details
    Browse the repository at this point in the history

  5. validate the default attribute of Boolean

    @maximlt
    maximlt committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    81cd1b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. add __repr__ to Undefined

    @maximlt
    maximlt committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    68b6e01 View commit details
    Browse the repository at this point in the history

  2. improve docs on inheritance

    @maximlt
    maximlt committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    2e19f34 View commit details
    Browse the repository at this point in the history

  3. add docstring to _compute_selector_default

    @maximlt
    maximlt committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    9e3f2a9 View commit details
    Browse the repository at this point in the history

  4. add comment on empty_default

    @maximlt
    maximlt committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0ca0042 View commit details
    Browse the repository at this point in the history