Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert param accessor to weakref #384

Closed
wants to merge 1 commit into from
Closed

Convert param accessor to weakref #384

wants to merge 1 commit into from

Conversation

philippjfr
Copy link
Member

Avoids creating circular reference between Parameterized and Parameters objects.

@philippjfr
Copy link
Member Author

I think using a property is probably safer and easier tbh, will push that up tomorrow.

@philippjfr philippjfr mentioned this pull request Apr 9, 2020
Merged
@philippjfr
Copy link
Member Author

weakrefs won't pickle so a property definitely seems preferable.

@philippjfr philippjfr closed this Apr 9, 2020
@maximlt maximlt mentioned this pull request Jun 21, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbednar jbednar jbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippjfr @jbednar