Validate type of param.Boolean default value (#722)

holoviz · Mar 27, 2023 · 7ece88c · 7ece88c
1 parent f338d19
commit 7ece88c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/param/__init__.py b/param/__init__.py
@@ -999,6 +999,7 @@ class Boolean(Parameter):
     def __init__(self, default=False, bounds=(0,1), **params):
         self.bounds = bounds
         super(Boolean, self).__init__(default=default, **params)
+        self._validate(default)
 
     def _validate_value(self, val, allow_None):
         if allow_None:
@@ -1007,8 +1008,11 @@ def _validate_value(self, val, allow_None):
                                  "Boolean value or None, not %s."
                                  % (self.name, val))
         elif not isinstance(val, bool):
-            raise ValueError("Boolean parameter %r must be True or False, "
-                             "not %s." % (self.name, val))
+            name = "" if self.name is None else " %r" % self.name
+            raise ValueError("Boolean parameter%s must be True or False, not %s." % (name, val))
+
+    def _validate(self, val):
+        self._validate_value(val, self.allow_None)
 
 
 

diff --git a/tests/API1/testbooleanparam.py b/tests/API1/testbooleanparam.py
@@ -79,6 +79,13 @@ def test_bad_type(self):
         with self.assertRaisesRegex(ValueError, msg):
             p.e = 'test'
 
+    def test_bad_default_type(self):
+        msg = r"Boolean parameter must be True or False, not test."
+
+        with self.assertRaisesRegex(ValueError, msg):
+            class A(param.Parameterized):
+                b = param.Boolean(default='test')
+
 
 class TestEventParameters(API1TestCase):