Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added daskgeopandas check to is_geodataframe function #1396

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

Azaya89
Copy link
Contributor

@Azaya89 Azaya89 commented Aug 21, 2024

  • Modified the is_geodataframe function to support DaskGeoDataFrame

  • Test added.

hvplot/tests/testutil.py Outdated Show resolved Hide resolved
@ahuang11
Copy link
Collaborator

Looks good to me! Just a minor addition.

Comment on lines 378 to 379
import dask.dataframe as dd
import spatialpandas as spd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other thought are these can be moved up, and the pytest.mark.skipif can check if dd or spd is None.

Suggested change
import dask.dataframe as dd
import spatialpandas as spd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Done

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.80%. Comparing base (6c96c7e) to head (ded8eb9).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
hvplot/tests/testutil.py 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
+ Coverage   87.39%   88.80%   +1.40%     
==========================================
  Files          50       51       +1     
  Lines        7490     7510      +20     
==========================================
+ Hits         6546     6669     +123     
+ Misses        944      841     -103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hvplot/util.py Outdated Show resolved Hide resolved
@Azaya89 Azaya89 requested a review from ahuang11 August 30, 2024 09:18
hvplot/tests/testutil.py Outdated Show resolved Hide resolved
@ahuang11
Copy link
Collaborator

Thank you looks good now!

@ahuang11 ahuang11 merged commit 07b034f into holoviz:main Sep 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants