-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hover_tooltips, hover_formatters, hover_mode #1385
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
+ Coverage 87.39% 88.86% +1.47%
==========================================
Files 50 51 +1
Lines 7490 7500 +10
==========================================
+ Hits 6546 6665 +119
+ Misses 944 835 -109 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but as a monitor rather than a maintainer for hvPlot, I'm not sure if my approval is sufficient to merge, so you might want to wait for Maxime to review or ask another maintainer.
I've got a few comments. Doesn't
Adding tests is pretty much always worth in my opinion, in particular when they're easy to write. I would suggest alphabetically ordering the new We need to find a way to better document these sorts of options. As it stands, I don't think the docs provide sufficient information for users to leverage these new parameters. |
Filed as an issue for follow up |
Adds opts from holoviz/holoviews#6180
Don't think a test is required since it's just adding plot_opts?