Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: also install the dependencies with pip #1276

Merged
merged 25 commits into from
Feb 25, 2024
Merged

CI: also install the dependencies with pip #1276

merged 25 commits into from
Feb 25, 2024

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Feb 10, 2024

This PR brings changes to the CI:

  • The main tests install now the dependencies using pip. Conda tests are run on a scheduled base, on releases and on part of downstream tests.
  • When the docs are built with conda, another job also builds them - without publishing - with pip.

Overall, I was impressed by how things improved in the pip world, most packages can be installed without any issue on the 3 platforms. Some remaining issues:

  • pygraphviz has no wheel and requires some special setup to build from the sdist. Since it's just required to build the user_guide/NetworkX.ipynb notebook, I've put it in its own graphviz extra, that is only pulled when the docs/tests jobs run with conda.
  • cartopy cannot be installed on Python 3.8 on Ubuntu and Windows. I've created a geo extra to deal with that similarly to graphviz. Starting from 3.9 it looks like it will no longer be required!

When these dependencies are not installed, the notebooks that need them are skipped.

@maximlt maximlt changed the title CI: try pip again Also install the dependencies with pip on the CI Feb 25, 2024
@maximlt maximlt changed the title Also install the dependencies with pip on the CI CI: also install the dependencies with pip Feb 25, 2024
@maximlt maximlt merged commit 6be9cac into main Feb 25, 2024
9 checks passed
@maximlt maximlt deleted the ci_try_pip branch February 25, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant