Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Pandas 2.2 #1257

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Compatibility with Pandas 2.2 #1257

merged 2 commits into from
Jan 28, 2024

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jan 22, 2024

  • Vendoring some of the make<> private testing utilities that were removed in Pandas 2.2
  • Update a test to remove a FutureWarning

@@ -194,7 +195,7 @@ def sel_col(sel):


def test_interactive_nested_widgets():
df = pd._testing.makeDataFrame()
df = makeDataFrame()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's start using the fixture more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The df fixture in this module that retunes makeMixedDataFrame is used a lot. Planning to refactor the tests in a future PR.

@maximlt maximlt merged commit 6aff909 into main Jan 28, 2024
8 checks passed
@maximlt maximlt deleted the tests_compat_pandas2.2 branch January 28, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants