Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change GeoViews to geoviews (import name) #1005

Merged
merged 3 commits into from
Dec 9, 2022
Merged

change GeoViews to geoviews (import name) #1005

merged 3 commits into from
Dec 9, 2022

Conversation

raybellwaves
Copy link
Contributor

No description provided.

@maximlt
Copy link
Member

maximlt commented Dec 7, 2022

Thanks! Why did you remove pyproj?

@raybellwaves
Copy link
Contributor Author

raybellwaves commented Dec 7, 2022

Thanks! Why did you remove pyproj?

I put it in the commit message but should have explained here: it's installed with cartopy

@maximlt
Copy link
Member

maximlt commented Dec 7, 2022

Indeed I missed that. I actually added pyproj recently, the fact that cartopy depends on pyproj is an implementation detail. Sure this is not meant to change any time soon, but well, I prefer to be explicit in these cases.

If that's fine for you I'll add it back?

@raybellwaves
Copy link
Contributor Author

np. just added it back in

@maximlt
Copy link
Member

maximlt commented Dec 9, 2022

Great thanks!

@maximlt maximlt merged commit ddd14cb into holoviz:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants