-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dimensioned streams #846
Dimensioned streams #846
Conversation
I thought I might as well give an example of how this is used: As the stream parameters 'x' and 'y' are listed in the kdims, you can index the |
Tests have passed except for one transient. There are several issues we are aware of but they won't be addressed in this PR.
Addressing these involves distinct tweaks to DynamicMap so it is probably worth merging this PR to continue with this work. |
Looks good to me and only affects DynamicMaps with streams. PRs to fix multiple dynamic calls and widgets to follow in separate PRs. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR implements dimensioned streams i.e support for streams with parameters listed in the key dimensions. This generalizes streams fully so that everything you can achieve with a regular DynamicMap can now be achieved using a stream (i.e our sliders could now use a streams based approach for dynamic maps).
I think this PR is mostly complete but it isn't quite ready yet. I would like to test it more, taking time to ensure that the counter and generator ('open') modes work correctly. In addition, I want to write some unit tests for the three new utility functions I've introduced as well as for dynamic maps with dimensioned streams.