Improved bokeh json patch computation #807
Conversation
Improved code that tidies up bokeh json patches to update plots. Should result in an overall reduction of 30-50% in the json size
philippjfr
force-pushed
the
bokeh_json_opt
branch
from
36094ba
to
621c3cd
Compare
|
This is ready to be merged now, I've been running off this branch for almost two weeks now without any issues and it really does represent a huge saving in the amount of data that is sent to the browser. |
| """ | ||
| Returns a list of all ids in the supplied object. | ||
| Useful for determining if a json representation contains | ||
| references to other objects. |
There was a problem hiding this comment.
Might be worth mentioning why this knowing if the JSON has references is useful information (if it can be summarized in a simple way).
|
Ok, hopefully two weeks worth of testing means it is robust! I am happy to merge once you've decided to either ignore/implement the two suggestions I've made in the comments. |
|
Just implemented your suggestions and improved various docstrings to make it a bit clearer how this stuff actually works. Ready to merge now. |
|
Looks good! Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Improved code that tidies up bokeh json patches to update plots. Should result in an overall reduction of 30-50% in the size of the json containing the plot updates.
Things to do:
I've now tested this on every bokeh based notebook I could find and have not encountered any issues. Very happy I could condense the plot updates this much!