Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure no auto index is created when a kdim is part of a multi index #6299

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jun 28, 2024

Fixes #6298

Code

import numpy as np
import pandas as pd
import holoviews as hv

hv.extension('bokeh')

dti = pd.date_range(start='1/1/2018', end='1/08/2018')

other = list(range(len(dti)))

t = pd.DataFrame(
    dict(
        n=range(5, len(dti) + 5),
        m=range(10, len(dti) + 10),
    )
)
dfm = pd.MultiIndex.from_frame(t)
df = pd.DataFrame(np.random.randn(len(dfm)), index=dfm, columns=['test'])
df.head()

p = hv.Curve(df, 'm', 'test')
p

image

@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.52%. Comparing base (febe075) to head (19bcee8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6299   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files         323      323           
  Lines       67996    67999    +3     
=======================================
+ Hits        60193    60196    +3     
  Misses       7803     7803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro enabled auto-merge (squash) June 28, 2024 16:55
@hoxbro hoxbro merged commit e5f7aed into main Jun 28, 2024
13 checks passed
@hoxbro hoxbro deleted the fix_multiindex branch June 28, 2024 17:06
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas interface doesn't handle kdims part of a Pandas MultiIndex
2 participants