Add color to bars for Plotly

[hoxbro]

Fixes #5658

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (e243fe0) to head (5d99c25).
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6294      +/-   ##
==========================================
- Coverage   88.55%   88.50%   -0.06%     
==========================================
  Files         323      323              
  Lines       68000    68079      +79     
==========================================
+ Hits        60218    60250      +32     
- Misses       7782     7829      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hoxbro]

Is there a better method to put this in?

[maximlt]

I don't think making color a plot option is the right approach here. I've tried something else that seemed to work, it'd need some more testing and unit tests.

I'm also not sure what convention HoloViews follows on naming style options, does it attempt to standardize them across backends or does it instead try to stay closer to the backend naming scheme?

diff --git a/holoviews/plotting/plotly/chart.py b/holoviews/plotting/plotly/chart.py
index a7a831bbd..bcb7c82ee 100644
--- a/holoviews/plotting/plotly/chart.py
+++ b/holoviews/plotting/plotly/chart.py
@@ -198,9 +198,7 @@ class BarPlot(BarsMixin, ElementPlot):
     show_legend = param.Boolean(default=True, doc="""
         Whether to show legend for the plot.""")
 
-    color = param.String(default=None, doc="The color of the bars.")
-
-    style_opts = ['visible']
+    style_opts = ['visible', 'color']
 
     selection_display = PlotlyOverlaySelectionDisplay()
 
@@ -281,12 +279,14 @@ class BarPlot(BarsMixin, ElementPlot):
                     for d in (xdim, group_dim)],
                 y: np.nan_to_num(values)})
 
-        if self.color:
-            for bar in bars:
-                bar['marker_color'] = self.color
-
         return bars
 
+    def graph_options(self, element, ranges, style, **kwargs):
+        if 'color' in style:
+            style['marker_color'] = style.pop('color')
+        opts = super().graph_options(element, ranges, style, **kwargs)
+        return opts
+
     def init_layout(self, key, element, ranges, **kwargs):
         layout = super().init_layout(key, element, ranges)
         stack_dim = None

[maximlt]

it'd need some more testing and unit tests.

@hoxbro in fact you already added a test which I didn't need to touch, so we're good.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.