Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable batching when subcoordinate_y is enabled #6272

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Conversation

philippjfr
Copy link
Member

Batching kicks in when you are plotting more than legend_limit elements inside an NdOverlay. However for a subcoordinate_y plot batching is not and cannot be supported since each element has to be plotted using a different renderer instance. Therefore we check if subcoordinate_y is enabled before enabling batching.

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Jun 10, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (7e5b515) to head (2a0a6fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6272   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         323      323           
  Lines       67934    67945   +11     
=======================================
+ Hits        60146    60157   +11     
  Misses       7788     7788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to test this?

holoviews/plotting/plot.py Show resolved Hide resolved
@hoxbro hoxbro merged commit 81f5f66 into main Jun 10, 2024
14 checks passed
@hoxbro hoxbro deleted the subcoordinate_batching branch June 10, 2024 13:43
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants