Make Dimension.label source of truth for Dimension identity

[philippjfr]

Implements #6260

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 88.52%. Comparing base (9cc87fe) to head (7b0f15f).
Report is 9 commits behind head on main.

Files	Patch %	Lines
holoviews/plotting/mixins.py	61.53%	5 Missing ⚠️
holoviews/plotting/mpl/chart.py	69.23%	4 Missing ⚠️
holoviews/plotting/bokeh/graphs.py	0.00%	2 Missing ⚠️
holoviews/plotting/mpl/graphs.py	0.00%	2 Missing ⚠️
holoviews/plotting/util.py	71.42%	2 Missing ⚠️
holoviews/plotting/bokeh/path.py	50.00%	1 Missing ⚠️
holoviews/plotting/plotly/chart.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6262      +/-   ##
==========================================
+ Coverage   88.47%   88.52%   +0.04%     
==========================================
  Files         323      323              
  Lines       67647    67906     +259     
==========================================
+ Hits        59853    60116     +263     
+ Misses       7794     7790       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hoxbro]

My rough understanding is that dim.name will be used for data access, e.g., looking up a column in a DataFrame and dim.label will be used by HoloViews for ranges etc. Is this an ok (rough) understanding?

How thoroughly have you checked the codebase for this find and replace? The code still seems to use name for range lookup.

holoviews/holoviews/plotting/util.py

Line 411 in c8e7f5f

drange = ranges[dimension.name]['data']

holoviews/holoviews/operation/normalization.py

Line 109 in c8e7f5f

return {d.name: element.range(d.name, self.data_range)

Have you checked if hvplot / GeoViews need updating too?

[philippjfr]

Is this an ok (rough) understanding?

Yes.

How thoroughly have you checked the codebase for this find and replace? The code still seems to use name for range lookup.

Clearly not quite thoroughly enough, will do another more exhaustive check now.

Have you checked if hvplot / GeoViews need updating too?

Yes.

[philippjfr]

Did miss quite a few. Will scan more thoroughly one more time. Note that this only affects plotting code, so e.g. this isn't affected:

holoviews/holoviews/operation/normalization.py

Line 109 in c8e7f5f

 return {d.name: element.range(d.name, self.data_range) 

[philippjfr]

Okay, quite confident now, thoroughly reviewed the plotting code and replaced all remaining cases.

[philippjfr]

I think the only way we'll catch any more cases will be if we merge and include the change in the RC release.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.