Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure plot ranges for all renderers are combined in auto-ranging #6173

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 4, 2024

Fixes a small oversight in the auto-ranging implementation by combining the ranges for all renderers instead of overwriting them. Also simplifies the code by using the new Bokeh.index.find_one API instead of rolling our own implementation.

Fixes #6033

  • Add UI test

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Apr 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.68%. Comparing base (342d81c) to head (baa8feb).
Report is 5 commits behind head on main.

❗ Current head baa8feb differs from pull request most recent head 633ea9b. Consider uploading reports for the commit 633ea9b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6173   +/-   ##
=======================================
  Coverage   88.68%   88.68%           
=======================================
  Files         316      316           
  Lines       66072    66072           
=======================================
  Hits        58598    58598           
  Misses       7474     7474           
Flag Coverage Δ
ui-tests 23.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr marked this pull request as ready for review April 12, 2024 16:08
@philippjfr philippjfr requested a review from hoxbro April 12, 2024 16:08
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code to work with overlay. Can you please review those changes?

Other than that, it looks good to me; you can merge after looking at my changes.

holoviews/plotting/bokeh/element.py Show resolved Hide resolved
holoviews/plotting/bokeh/element.py Show resolved Hide resolved
@hoxbro hoxbro merged commit 2d6f46f into main Apr 15, 2024
11 checks passed
@hoxbro hoxbro deleted the autorange_multiple branch April 15, 2024 14:10
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoranging on multi-line plots limits view to a single line
4 participants