Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise KeyError if options don't contain None #6153

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Mar 16, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.68%. Comparing base (baa69b1) to head (6fbc238).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6153   +/-   ##
=======================================
  Coverage   88.68%   88.68%           
=======================================
  Files         316      316           
  Lines       66018    66018           
=======================================
  Hits        58545    58545           
  Misses       7473     7473           
Flag Coverage Δ
ui-tests 23.79% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label Mar 16, 2024
@hoxbro hoxbro changed the title Don't raise KeyError if options don't contain empty Don't raise KeyError if options don't contain None Mar 16, 2024
@hoxbro hoxbro merged commit 6a7fedc into main Mar 18, 2024
11 of 12 checks passed
@hoxbro hoxbro deleted the empty_options branch March 18, 2024 10:56
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants