Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for downsample algorithms #6083

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Add test for downsample algorithms #6083

merged 4 commits into from
Jan 29, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 25, 2024

Add simple tests to check if we can run the downsample algorithms.

Unimport is inspired by this: https://mastodon.social/@sscherfke/111116160705738755

It seems like tsdownsample is not available on Windows on conda-forge.

@hoxbro hoxbro added the type: enhancement Minor feature or improvement to an existing feature label Jan 25, 2024
@hoxbro hoxbro requested a review from maximlt January 25, 2024 10:08
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (48aa328) 88.65% compared to head (0f9435a) 88.68%.

Files Patch % Lines
holoviews/tests/operation/test_downsample.py 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6083      +/-   ##
==========================================
+ Coverage   88.65%   88.68%   +0.02%     
==========================================
  Files         314      314              
  Lines       65841    65872      +31     
==========================================
+ Hits        58371    58418      +47     
+ Misses       7470     7454      -16     
Flag Coverage Δ
ui-tests 23.68% <39.39%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spending time writing these tests :) I left a few comments.

setup.py Show resolved Hide resolved
holoviews/tests/operation/test_downsample.py Show resolved Hide resolved
holoviews/tests/conftest.py Show resolved Hide resolved
@hoxbro hoxbro merged commit 30044d4 into main Jan 29, 2024
12 checks passed
@hoxbro hoxbro deleted the downsample_test branch January 29, 2024 09:08
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants