Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use importlib.version to remove import from show_versions #6072

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 16, 2024

Mainly to speed up the time it takes to run the command.

Also adds pyviz_comms to the list.

@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label Jan 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (62b7f1e) 88.65% compared to head (03d38d5) 88.66%.
Report is 2 commits behind head on main.

Files Patch % Lines
holoviews/util/_versions.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6072      +/-   ##
==========================================
+ Coverage   88.65%   88.66%   +0.01%     
==========================================
  Files         314      314              
  Lines       65688    65764      +76     
==========================================
+ Hits        58234    58310      +76     
  Misses       7454     7454              
Flag Coverage Δ
ui-tests 23.65% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro changed the title Use importlib.version to speed up import time Use importlib.version to remove import from show_versions Jan 16, 2024
@hoxbro hoxbro enabled auto-merge (squash) January 16, 2024 08:13
@hoxbro hoxbro merged commit ee80117 into main Jan 16, 2024
13 checks passed
@hoxbro hoxbro deleted the use_importlib branch January 16, 2024 08:47
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants