Only evaluate rx if it is an Reactive Expression
#6014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6014 +/- ##
==========================================
+ Coverage 88.62% 88.65% +0.03%
==========================================
Files 315 314 -1
Lines 65607 65688 +81
==========================================
+ Hits 58142 58234 +92
+ Misses 7465 7454 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
With this fix, the function is called only once. Also, it does not reintroduce #6008 |
hoxbro
changed the title
rx if it is an Reactive Expression
hoxbro
added a commit
that referenced
this pull request
Feb 2, 2024
Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should improve what is seen in #6013
Want to add a UI test that checks that the bound function is only run once.