Part 1, modernize test suite #5954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
commented
Oct 25, 2023
| @@ -44,6 +44,7 @@ def setUp(self): | |||
| except Exception: | |||
| raise SkipTest("IPython could not be started") | |||
|
|
|||
| self.ip.displayhook.flush = lambda: None # To avoid gc.collect called in it | |||
There was a problem hiding this comment.
This is not directly related to any failing test but gives a significant overhead when running the test suite.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5954 +/- ##
==========================================
- Coverage 88.58% 88.57% -0.01%
==========================================
Files 315 315
Lines 65573 65576 +3
==========================================
- Hits 58086 58085 -1
- Misses 7487 7491 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
philippjfr
approved these changes
Nov 22, 2023
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of many parts, which will begin two tasks for the HoloViews test suite:
unittestframework withself.assertEqualand replace it with pytest.1.a. I plan to have an
assert_element_equalfor comparison of holoviews elements and then useassert,{np, pd, xr}.testingfor types not directly HoloViews type. This will make it easier to see what is being tested at a glance.2.a. Be able to use fixtures. I have in this PR added
bokeh_backend,mpl_backend, andplotly_backend.pytest-xdist. ref Test suite are sensitive to run order #5565The focus of this PR has been updating the test, which saves files to disk; this has been done by using pytest
tmp_pathand minor updates to supportpathlibfor these methods.The second part is
test_statselements.py, whereTestStatisticalCompositorwas sensitive to the run order because it neededhv.renderer('matplotlib')to be called. I have updated the whole file to pytest.