Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HeatMap and QuadMesh test to pass on Matplotlib 3.8 #5924

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 5, 2023

Fixes #5896

It needs #5910 to be fully compatible with Matplotlib 3.8.

@hoxbro hoxbro marked this pull request as draft October 5, 2023 15:09
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Merging #5924 (e72c496) into main (3da3d75) will decrease coverage by 0.01%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##             main    #5924      +/-   ##
==========================================
- Coverage   88.58%   88.57%   -0.01%     
==========================================
  Files         315      315              
  Lines       65442    65460      +18     
==========================================
+ Hits        57972    57984      +12     
- Misses       7470     7476       +6     
Flag Coverage Δ
ui-tests 23.16% <14.70%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
holoviews/tests/plotting/matplotlib/test_plot.py 100.00% <100.00%> (ø)
...iews/tests/plotting/matplotlib/test_heatmapplot.py 91.42% <76.92%> (-8.58%) ⬇️
...ews/tests/plotting/matplotlib/test_quadmeshplot.py 92.85% <83.33%> (-7.15%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro
Copy link
Member Author

hoxbro commented Oct 16, 2023

percent_bachelors_degrees_women_usa.csv is removed in Matplotlib 3.8 ref, so I have uploaded it to datasets.holoviz.org now.

@hoxbro hoxbro marked this pull request as ready for review October 16, 2023 16:57
@hoxbro hoxbro enabled auto-merge (squash) October 16, 2023 16:58
@hoxbro hoxbro merged commit eccd230 into main Oct 16, 2023
10 checks passed
@hoxbro hoxbro deleted the mpl38 branch October 16, 2023 18:21
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin matplotlib 3.8
2 participants