plotly title font size fix

[jj-github-jj]

Fixes #5919

fixes plotly title font size

[hoxbro]

Thank you for your contribution +1:

I think it would be cleaner to do something like this. What do you think?

  def _format_title(self, key, separator=' '):
      """
      Formats the title of the plot.
      """
      title = super()._format_title(key, separator)

      if self.fontsize is not None and "title" in self.fontsize:
          title = {"text": title, "font": {"size": self.fontsize["title"]}}

      return title

A test that confirms that the text size is correct would also be good to have. Which should be possible with hv.render(plot).

And the failing test is likely not related to your PR.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (dd0e4d5) to head (c10ee0c).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5920   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         323      323           
  Lines       67797    67806    +9     
=======================================
+ Hits        60021    60030    +9     
  Misses       7776     7776           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jj-github-jj]

Thank you for your contribution +1:

I think it would be cleaner to do something like this. What do you think?

  def _format_title(self, key, separator=' '):
      """
      Formats the title of the plot.
      """
      title = super()._format_title(key, separator)

      if self.fontsize is not None and "title" in self.fontsize:
          title = {"text": title, "font": {"size": self.fontsize["title"]}}

      return title

A test that confirms that the text size is correct would also be good to have. Which should be possible with hv.render(plot).

And the failing test is likely not related to your PR.

Agree with your changes. Thanks

[hoxbro]

Are you up for implementing them?

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.