Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Path.datatype parameter type #5897

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix Path.datatype parameter type #5897

merged 1 commit into from
Sep 19, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Sep 19, 2023

From ObjectSelector to List, List being the type of datatype in the base class Dataset.

@hoxbro hoxbro enabled auto-merge (squash) September 19, 2023 10:28
@hoxbro
Copy link
Member

hoxbro commented Sep 19, 2023

Looks good. I have enabled auto-merge for this PR. If you are not finished with please disable it 👍

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #5897 (d17d38d) into main (70e7d5a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5897   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files         312      312           
  Lines       64943    64943           
=======================================
+ Hits        57411    57412    +1     
+ Misses       7532     7531    -1     
Flag Coverage Δ
ui-tests 23.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/element/path.py 86.87% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit 63a1cda into main Sep 19, 2023
11 checks passed
@hoxbro hoxbro deleted the update_param_type_datatype branch September 19, 2023 11:38
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants