Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Numpy 1.25 #5870

Merged
merged 13 commits into from
Sep 6, 2023
Merged

Support Numpy 1.25 #5870

merged 13 commits into from
Sep 6, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 29, 2023

With numpy 1.25 this would error previously:

python -c "import holoviews as hv; hv.dim('float').var(ddof=0)"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/shh/Repos/holoviz/holoviews/holoviews/util/transform.py", line 490, in var
    def var(self, *args, **kwargs):      return type(self)(self, np.var, *args, **kwargs)
                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/shh/Repos/holoviz/holoviews/holoviews/util/transform.py", line 278, in __init__
    any(fn in funcs for funcs in self._all_funcs)):
                                 ^^^^^^^^^^^^^^^
  File "/home/shh/Repos/holoviz/holoviews/holoviews/util/transform.py", line 315, in __getattribute__
    ops = super().__getattribute__('ops')
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'dim' object has no attribute 'ops'

I also added a CI run that only runs test-core always to be able to test the latest numpy and pandas.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Merging #5870 (25878cc) into main (0f6ed70) will decrease coverage by 0.13%.
The diff coverage is 62.96%.

@@            Coverage Diff             @@
##             main    #5870      +/-   ##
==========================================
- Coverage   88.34%   88.22%   -0.13%     
==========================================
  Files         310      310              
  Lines       63960    63981      +21     
==========================================
- Hits        56508    56445      -63     
- Misses       7452     7536      +84     
Flag Coverage Δ
ui-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/__init__.py 70.96% <0.00%> (ø)
holoviews/tests/util/test_utils.py 96.34% <57.14%> (-3.66%) ⬇️
holoviews/tests/core/data/test_imageinterface.py 99.42% <60.00%> (-0.58%) ⬇️
holoviews/tests/util/test_transform.py 95.75% <60.00%> (-1.21%) ⬇️
holoviews/tests/element/test_selection.py 98.11% <100.00%> (ø)
holoviews/util/transform.py 86.18% <100.00%> (-0.03%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit 3bdde22 into main Sep 6, 2023
15 checks passed
@hoxbro hoxbro deleted the numpy_1.25 branch September 6, 2023 07:37
ahuang11 pushed a commit that referenced this pull request Sep 9, 2023
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants