Disable Dask's conversion of strings in test #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
changed the title
hoxbro
changed the title
philippjfr
reviewed
Jul 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #5819 +/- ##
==========================================
+ Coverage 88.17% 88.19% +0.02%
==========================================
Files 307 307
Lines 62989 63214 +225
==========================================
+ Hits 55539 55753 +214
- Misses 7450 7461 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://docs.dask.org/en/stable/changelog.html#v2023-7-1
In the future, we should look into how our library handles the pyarrow backend in pandas. This should be done with
pd.options.mode.string_storage = "pyarrow"ref.But this seems like a bigger undertaking and for now this make our test go green again.